Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: remove permissions for patch/update nodes and webhook resources #3932

Closed

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Aug 23, 2024

Thanks for contributing!

What type of PR is this?

  • release/bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3882

Special notes for your reviewer:

Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (664516b) to head (a52989a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-v0.8    #3932   +/-   ##
=============================================
  Coverage         81.49%   81.49%           
=============================================
  Files                49       49           
  Lines              4340     4340           
=============================================
  Hits               3537     3537           
  Misses              641      641           
  Partials            162      162           
Flag Coverage Δ
unittests 81.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cyclinder
Copy link
Collaborator Author

this PR shouldn't cherry-pick to release-v0.8, only main branch.

@cyclinder cyclinder closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant